[Webkit-unassigned] [Bug 34924] New: Add checks if setNeedsWillValidateCheck() and setNeedsValidityCheck() are called correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 14 05:11:09 PST 2010


           Summary: Add checks if setNeedsWillValidateCheck() and
                    setNeedsValidityCheck() are called correctly
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tkent at chromium.org
                CC: darin at apple.com
        Depends on: 31716

> It almost seems that despite our bad experiences, caching the old value would
> be helpful, not for optimizing the result of the functions to fetch the
> validity state, but for getting the state changes correct. It's quite fragile
> to both have functions to answer "is this valid" and then scattered code to
> invalidate when those constraints change. How would someone changing the
> functions know to go update the call sites where those states could change.
> How would notice if we forgot to call one of these state change functions?
> Maybe we need to devise a debugging feature to catch mistakes.
> If we do cache a value I think it should be a single three-state concept: "will
> not validate", "valid", "invalid". Treating these as independent makes the code
> more complicated in places where they overlap. I know the DOM API for this
> treats them separately, but the style code would be much simpler if it used a
> single three-state concept.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list