[Webkit-unassigned] [Bug 33478] Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 13 10:19:03 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33478


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48612|0                           |1
        is obsolete|                            |
  Attachment #48612|review?                     |
               Flag|                            |
  Attachment #48708|                            |review?
               Flag|                            |




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2010-02-13 10:19:02 PST ---
Created an attachment (id=48708)
 --> (https://bugs.webkit.org/attachment.cgi?id=48708)
[PATCH] Proposed Fix

I looked into cases of what could appear after a color in a valid value:

  - '$' for cases like "color: red;" where the value is "red"
  - ')' for cases like -webkit-gradiant's "from(red)", "to", and "color-stop"

These can be put into a positive lookahead at the end of the regex. Timothy
Hatcher mentioned whitespace and a comma, which I think are acceptable to add
in even though I can't think of cases for them yet.

This lookahead assertion can be used for all cases of colors, but is only
practically useful for the \b\w+\b word section, so the patch only uses it
there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list