[Webkit-unassigned] [Bug 34885] [Qt] QGraphicsWebView should have a mode that makes it automatically resize itself to the content size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34885





--- Comment #6 from Antti Koivisto <koivisto at iki.fi>  2010-02-12 06:51:05 PST ---
(In reply to comment #3)
>  +void QGraphicsWebViewPrivate::_q_contentsSizeChanged(QSize size)
> 
> Preference: I'd use a const QSize& here

fixed

> I think it would be nice to tie this feature to an action in the GUI instead of
> the commandline. The commandline is "hard" to use on Symbian. I find it easier
> to tap through the menu. For example it could be a simple checkable action in
> the "Developer" menu.

yeah, but better handled separately

> When the feature is disabled, shouldn't we disconnect from the
> contentsSizeChanged signal?

fixed (though this is probably usually one time thing)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.