[Webkit-unassigned] [Bug 34874] [Qt] Unnecessary QBrush construction for doing a solid color stroke

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34874





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-12 04:31:50 PST ---
(From update of attachment 48616)

> +++ b/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
> @@ -1112,7 +1112,8 @@ void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace colo
>          return;
>      QPainter* p = m_data->p();
>      QPen newPen(p->pen());
> -    newPen.setColor(color);
> +    m_data->solidColor.setColor(color);
> +    newPen.setBrush(m_data->solidColor);
>      p->setPen(newPen);
>  }
>  

For me this code is not so clear, so maybe a comment would help?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.