[Webkit-unassigned] [Bug 34885] [Qt] QGraphicsWebView should have a mode that makes it automatically resize itself to the content size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34885





--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2010-02-12 04:23:48 PST ---
 +void QGraphicsWebViewPrivate::_q_contentsSizeChanged(QSize size)

Preference: I'd use a const QSize& here


> --- WebKit/qt/QGVLauncher/main.cpp	(revision 54651)
> +++ WebKit/qt/QGVLauncher/main.cpp	(working copy)
> @@ -74,6 +74,8 @@ public:
>      {
>          if (QApplication::instance()->arguments().contains("--cacheWebView"))
>              setCacheMode(QGraphicsItem::DeviceCoordinateCache);
> +        if (QApplication::instance()->arguments().contains("--resizesToContent"))
> +            setResizesToContent(true);

I think it would be nice to tie this feature to an action in the GUI instead of
the commandline. The commandline is "hard" to use on Symbian. I find it easier
to tap through the menu. For example it could be a simple checkable action in
the "Developer" menu.


> +void QGraphicsWebView::setResizesToContent(bool enabled)
> +{
> +    d->resizesToContent = enabled;
> +    if (enabled && d->page)
> +        d->enableResizesToContentForPage();
> +}

When the feature is disabled, shouldn't we disconnect from the
contentsSizeChanged signal?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.