[Webkit-unassigned] [Bug 34864] Many objects left uncollected after visiting mail.google.com and closing window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34864





--- Comment #8 from Geoffrey Garen <ggaren at apple.com>  2010-02-11 21:02:50 PST ---
> What is the reasoning for that rule? I'm sure it's a good idea, but I think
> SmallStrings::markChildren should have a "why" comment in it explaining why it
> is.

Added this comment:

    /*
       Our hypothesis is that small strings are very common. So, we cache them
       to avoid GC churn. However, in cases where this hypothesis turns out to
       be false -- including the degenerate case where all JavaScript execution
       has terminated -- we don't want to waste memory.

       To test our hypothesis, we check if any small string has been marked. If
       so, it's probably reasonable to mark the rest. If not, we clear the
cache.
     */

> > +        if (isMarked(m_singleCharacterStrings[i]))
> > +            isAnyStringMarked = true;
> 
> I suggest just doing assignment here instead of an if statement to save a
> branch.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.