[Webkit-unassigned] [Bug 34864] Many objects left uncollected after visiting mail.google.com and closing window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34864





--- Comment #6 from Darin Adler <darin at apple.com>  2010-02-11 20:42:05 PST ---
(From update of attachment 48619)
> +        Don't unconditionally hang onto small strings. Instead, hang onto all
> +        small strings as long as any small string is still referenced.

What is the reasoning for that rule? I'm sure it's a good idea, but I think
SmallStrings::markChildren should have a "why" comment in it explaining why it
is.

> +        if (isMarked(m_singleCharacterStrings[i]))
> +            isAnyStringMarked = true;

I suggest just doing assignment here instead of an if statement to save a
branch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.