[Webkit-unassigned] [Bug 33478] Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33478


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48612|                            |review?
               Flag|                            |




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org>  2010-02-11 19:48:32 PST ---
Created an attachment (id=48612)
 --> (https://bugs.webkit.org/attachment.cgi?id=48612)
[PATCH] Smarter Regex

These two lines from StylesSidebarPane are where the action is:

> var colorRegex = /((?:rgb|hsl)a?\([^)]+\)|#[0-9a-fA-F]{6}|#[0-9a-fA-F]{3}|\b\w+\b)/g;
> var colorProcessor = processValue.bind(window, colorRegex, processColor, null);

The colorRegex's "\b\w+\b" breaks down "after-white-space" and pulls out the
"white" in the middle. My simple solution was to throw a negative lookahead at
the end of this section ensuring there isn't a "-" after this text. But I want
to field you guys for some other possible edge cases, or solutions. My simple
patch is attached.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.