[Webkit-unassigned] [Bug 34812] [Android] SVG code in V8 bindings is not properly guarded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34812





--- Comment #10 from David Levin <levin at chromium.org>  2010-02-11 08:16:51 PST ---
(In reply to comment #8)
> Especially since any WebKit developer understands the "#if
> ENABLE" logic but not necessarily the GYP/Makefile logic.

btw, if you look at
https://bugs.webkit.org/attachment.cgi?id=48518&action=prettypatch , you'll see
that a file was incorrectly included in the if ENABLE.

Also if you look at
https://bugs.webkit.org/attachment.cgi?id=48520&action=prettypatch , you'll see
that the if ENABLE was done incorrectly.

The point being that the if ENABLE stuff can be hard to get right for including
the headers as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.