[Webkit-unassigned] [Bug 34812] [Android] SVG code in V8 bindings is not properly guarded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34812


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dglazkov at chromium.org,
                   |                            |jorlow at chromium.org




--- Comment #8 from Jeremy Orlow <jorlow at chromium.org>  2010-02-11 05:16:03 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > >   #if ENABLE(SVG) 
> > > to exclude headers should be removed. The headers themselves should have the if
> > > inside of them.
> > Is that also the case for generated headers? Having the guard around the
> > include site means that generated headers for unsupported features don't need
> > to be built.
> 
> I see what you are saying. I though the idl typically had the correct guard
> specified, so the header is generated with the appropriate if ENABLE.
> 
> But you're right that this means the header is generated when it doesn't need
> to be.  If at all possible, I think that is better than adding extra clutter to
> the files.

For the record, I'm not sure I agree.  Making the build logic more complicated
in order to save a couple lines of pre-processor here and there really seems
like a net loss.  Especially since any WebKit developer understands the "#if
ENABLE" logic but not necessarily the GYP/Makefile logic.

https://bugs.webkit.org/show_bug.cgi?id=34814 and
https://bugs.webkit.org/show_bug.cgi?id=34815

seem a lot worse than simply adding these guards whenever we're including files
that are generated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.