[Webkit-unassigned] [Bug 34829] [gtk] WebKitDownload's currentSize property is guint, should be guint64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 04:50:49 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34829


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48546|review?                     |review-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-11 04:50:49 PST ---
(From update of attachment 48546)
Your patch works. You get a warning on line 758, though, which you should fix
before we land this (because Soup behaves correctly, and handles us a goffset
instead). I wonder if we could move all our file size usage in WebKitDownload
to goffset to be consistent/correct. I don't know why I didn't do that in the
first place =(.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list