[Webkit-unassigned] [Bug 25585] [Qt] Webkit in Qt does not have window.showModalDialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25585





--- Comment #12 from Yael <yael.aharon at nokia.com>  2010-02-10 17:55:34 PST ---
(In reply to comment #10)
> Qt expected files updated by http://trac.webkit.org/changeset/54568
> 
> But I'm not sure if
> platform/qt/http/tests/security/cross-frame-access-call-expected.txt is
> correct:
> -PASS: window.showModalDialog.call(targetWindow); should be 'TypeError: Result
> of expression 'window.showModalDialog' [undefined] is not an object.' and is.
> +*** FAIL: window.showModalDialog.call(targetWindow); should be 'TypeError:
> Result of expression 'window.showModalDialog' [undefined] is not an object.'
> but instead is undefined.
> 
> What do you think about it?

I actually think that this is the expected result. Mac port does not support
canRunModal in DRT, and their expected results reflect that. Since we do
support it, we have different results.
It all comes down to the fact that the implementation of canRunModal in
WebChromeClient.mm returns false when running in DRT, and ChromeClientQt.cpp
returns true. 
(this is being called from JSDOMWindow::getOwnPropertySlot() before we check
cross frames access rights)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.