[Webkit-unassigned] [Bug 34817] run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34817





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2010-02-10 17:10:29 PST ---
(From update of attachment 48530)
> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
> index 5a770ef..c09ec37 100644
> --- a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
> +++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

> @@ -265,6 +270,7 @@ class MacDriver(base.Driver):
>              # practice it shouldn't come up and the --help output warns
>              # about it anyway.
>              cmd += self._options.wrapper.split()
> +        # FIXME: Using arch here masks any possible file-not-found errors from a non-existant driver executable.
>          cmd += ['arch', '-i386', port._path_to_driver(), '-']

What you say is true, but you should still probably be calling arch -i386 $*
(unless you want to dump the fat binary logic that currently is in
run-webkit-tests

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
> index 4da32ad..83cf99d 100644
> --- a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
> +++ b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

did you mean to include this file?

-- dirk

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.