[Webkit-unassigned] [Bug 34185] REGRESSION: Mask not invalidating

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34185





--- Comment #12 from Beth Dakin <bdakin at apple.com>  2010-02-10 16:50:42 PST ---
(In reply to comment #11)
> 
> SVGStyledElement::svgAttributeChanged already calls both
> invalidateResourcesInAncestorChain and invalidateResources. I'm surprised that
> we still need an override in SVGMaskElement ::svgAttributeChanged  to call
> invalidateCanvasResources. But maybe it is still needed; it does seem that
> invalidateResourcesInAncestorChain does not invalidate its own resources.
> 

In this particular case, the SVGMaskElement is one of the ancestors, so
::svgAttributeChanged is not called for this mask; the code that I changed in
invalidateResourcesInAncestorChain() does the invalidating. In the case where
the mask is not the ancestor, you are correct that the problem is that
invalidateResourcesInAncestorChain() does not invalidate itself.

Thanks for the reviews! I am addressing your comments now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.