[Webkit-unassigned] [Bug 34538] audio engine: add Complex number class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 16:13:22 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34538


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48516|review?                     |review-
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2010-02-10 16:13:18 PST ---
(From update of attachment 48516)
I like everything about this except for the suffix Utilities. I think this file
would be just fine named Complex.h -- named after the typedef that's in it.

> +#include <stdio.h>

Why include this? We should not.

I'm going to say review- because I think we should not choose this filename.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list