[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34782


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #7 from David Levin <levin at chromium.org>  2010-02-10 10:50:12 PST ---
> diff --git a/WebCore/html/HTMLImageElement.cpp b/WebCore/html/HTMLImageElement.cpp

> +PassRefPtr<HTMLImageElement> HTMLImageElement::create(Document* doc, int width, int height)
> +{
> +    ASSERT(doc);
> +    HTMLImageElement* image = new HTMLImageElement(imgTag, doc);
> +    if (width >= 0)
> +        image->setWidth(width);
> +    if (height >= 0)
> +        image->setHeight(height);
> +    return image;

Shouldn't this be "return adoptRef(image);"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.