[Webkit-unassigned] [Bug 34783] Fix two issues on maxLength.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34783


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48461|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-02-10 10:49:35 PST ---
(From update of attachment 48461)
> +debug('<br />Non-dirty value');

It's better not to rely on markup in the debug function. I typically use
debug('') to make a blank line. Someone should clean this up a bit for future
tests.

The setNonDirtyValue affects a lot of different functions. There is not
sufficient test coverage for this. Each function that you changed to call
setNonDirtyValue needs a test that would fail if it was still calling setValue.

I'm going to say review- because of not enough test coverage. Everything else
seems OK in the patch. If I'm wrong about the test coverage, please let me
know.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.