[Webkit-unassigned] [Bug 33983] Setting HTMLSelectElement.length to remove elements is broken if the page has (or ever had) DOM mutation events registered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33983





--- Comment #9 from TAMURA, Kent <tkent at chromium.org>  2010-02-10 08:21:48 PST ---
(From update of attachment 47460)
It's not so easy to check whether the test results in this patch are correct or
not. We usually print "PASS" if a test passes.
I recommend to rewrite the tests in script-tests form.  You can see a lot of
examples in LayoutTests/fast/forms/script-tests/. You don't need to write
if(window.layoutTestController)... and function log(msg) for script-tests.

> -        for (size_t listIndex = 0; listIndex < items.size(); listIndex++) {
> -            if (items[listIndex]->hasLocalName(optionTag) && optionIndex++ >= newLen) {
> -                Element *item = items[listIndex];
> +        for (size_t i = 0; i < items.size(); ++i) {

I don't think the variable name "i" is wrong, but it seems there are no reason
to shorten the variable name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.