[Webkit-unassigned] [Bug 34773] [GTK] Hits assertion on history back, with page cache enabled, in specific conditions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34773


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-02-10 06:54:48 PST ---
(In reply to comment #1)
> Created an attachment (id=48496)
 --> (https://bugs.webkit.org/attachment.cgi?id=48496) [details]
> Disconnect adjustments, and reconnect them when needed

This looks very good to me, I have just a few questions/doubts:

- I don't think the test really needs to open new windows? I certainly got the
crashes without doing that.
- Do you really need the fourth page just for the PASS? Can't you just print
that  when you are back at the beginning or something? Or just get rid of it
completely, since the tests passes if you don't crash anyway.
- Do we really need the bit about saving the values in the adjustments?
Shouldn't that be set by the view when it's restored automatically through the
usual path? Or was that dependent on a new view being created?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.