[Webkit-unassigned] [Bug 34743] [Chromium] Implement WebFrameImpl::numberOfPages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34743





--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-10 06:03:03 PST ---
Thanks for your review! I checked printBegin and found printBegin and printEnd
are doing the same stuff as PrintContext::numberOfPages (printBegin returns the
number of pages). So, I think we don't need to add a new API. We can implement
layoutTestController.numberOfPages only with printBegin and printEnd. I'll
close this bug.

> At any rate, it seems like we should either make these features of the
> printing API, or we should create a new section in WebFrame that is
> dedicated to providing utilities for layout tests.

It seems there are 3 functions for layout tests (renderTreeAsText,
counterValueForElementById, and pageNumberForElementById). I'll open another
bug (or re-title this bug) to create a section for them. By the way, both
counterValueForElementById and pageNumberForElementById were putted by me and
you are right, I put them here because I wanted to put them nearby
renderTreeAsText.

> One more question:  is it necessary to be able to specify pageWidth
> and pageHeight in fractions of a pixel?  Do these need to be floats,
> or can they be integers?

I made them float just because PrintContext takes float parameters. As I don't
think we'll want to use float sized pages from layout tests, printBegin, which
takes WebSize (a struct which has two integers), is sufficient to implement
layoutTestController.numberOfPages.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.