[Webkit-unassigned] [Bug 34721] [Chromium] Refactor AutocompletePopupMenuClient into a base class, SuggestionsPopupMenuClient, and two derived classes, AutocompletePopupMenuClient and AutoFillPopupMenuClient

Wed Feb 10 01:28:35 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=34721

Tony Chang (Google) <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tony at chromium.org

--- Comment #18 from Tony Chang (Google) <tony at chromium.org>  2010-02-10 01:28:32 PST ---
(In reply to comment #16)
> (From update of attachment 48451 [details])
> Clearing flags on attachment: 48451
> 
> Committed r54586: <http://trac.webkit.org/changeset/54586>

The Chromium mac build appears to be broken with the following error:
cc1plus: warnings being treated as errors
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebKit/chromium/src/AutoFillPopupMenuClient.cpp:
In member function â€˜virtual void
WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex(unsigned int)â€™:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebKit/chromium/src/AutoFillPopupMenuClient.cpp:57:
warning: comparison between signed and unsigned integer expressions

However, the canary buildbot on build.chromium.org compiles just fine.  I think
it's just different versions of gcc and 4.2 gives the warning and 4.2.1
doesn't.

Anyway, fixed in http://trac.webkit.org/changeset/54589 .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.