[Webkit-unassigned] [Bug 33940] Address last round of review comments on r53607

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 01:10:05 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33940





--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-02-10 01:10:04 PST ---
>>> -            m_sheet = CSSStyleSheet::create(e, String(), document->inputEncoding());
>>> +            m_sheet = CSSStyleSheet::create(e, String(), KURL(), document->inputEncoding());
>> 
>> Why not use createInline here?
> 
> Done.

I lied.  This needs to pass in the inputEncoding.  We could make a createInline
that takes an input encoding, but it might not be worthwhile for this one call
site.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list