[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34782


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48457|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-02-09 22:13:01 PST ---
(From update of attachment 48457)
This is *so* funny. I have a similar patch on my machine that I started working
on earlier today. I chose to emphasize the fact that the create functions are
for use with JavaScript constructors by using the name createForJSConstructor
rather than just create for them. And I did the work for WebKit's built-in
JavaScript engine too, not just for V8. As you should.

You're also using some non-standard formatting here. In the WebKit project we
do not put each argument of a function on a separate line, even if there are
many of them.

The arguments should be "const String&" rather than "String". And we name
things "document", not "doc", in new code at least.

And we don't use PassRefPtr for local variables.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.