[Webkit-unassigned] [Bug 34777] [Qt] Make possible Qt DRT get a page number for element by ID

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34777


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |hausmann at webkit.org
     Ever Confirmed|0                           |1




--- Comment #3 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2010-02-09 20:18:29 PST ---
great catch !


(In reply to comment #2)
> Attachment 48445 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h:151:  Missing spaces
> around =  [whitespace/operators] [4]

pls fix this.

> WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:462:  Tests for
> true/false, null/non-null, and zero/non-zero should all be done without
> equality comparisons.  [readability/comparison_to_zero] [5]

well, generally the bot is right, but in this specific case we are comparing
|width| and |height| with '0', which makes the code easier to read for me than
using "!width", so i would not bother much , unless someone (reviewer) thinks
different.

otherwise, lgtm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.