[Webkit-unassigned] [Bug 34544] [Chromium] RenderTheme does not draw focus rings on SL for checkboxes, radio buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34544


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48248|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #10 from Timothy Hatcher <timothy at hatcher.name>  2010-02-09 07:48:58 PST ---
(From update of attachment 48248)

> ++ (NSView*)TCMInterposing_focusView;

Should have a space between the type and the star for ObjC types.

> +BOOL CurrentOSHasSetFocusRingStyleInBitmapBug()

You should use bool. Should start with a lowercase "c".

> +    UInt32 *pixelPlane = &pixel;
> +    UInt32 **pixelPlanes = &pixelPlane;

Put the stars next to the type here.

> +    NSBitmapImageRep *bitmap = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes:(unsigned char **)pixelPlanes

Use UInt8 to match the UInt32s used earlier. No space should be between the
type and stars.

> +    NSRectFill(NSMakeRect(0,0,1,1));

Spaces needed after the commas.

> +bool swizzle()

Could use a more descriptive name since the swizzles specific methods.

> +class ScopedFixer
> +{

Brace should go on the previous line.

> ++ (NSView*)TCMInterposing_focusView

Space between the star and ObjC type.

> +    NSView* view = [self TCMInterposing_focusView];

Srar should be next to the variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.