[Webkit-unassigned] [Bug 34694] [Qt] Fix QtLauncher compile on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34694


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.1.gombos at nokia.com




--- Comment #8 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-02-08 14:33:15 PST ---
This LGTM as a build-fix. Few minor comments:

noreturn attribute can be defined for other compilers as well not just for GCC
- the syntax for MSVC is "__declspec(noreturn)". A better solution would be:

#if defined(__GNUC__) // or Q_CC_GNU
#define NO_RETURN __attribute__ ((noreturn))
#elif defined(_MSC_VER) // or the Q_ equivalent
#define NO_RETURN __declspec(noreturn)
#else
#define NO_RETURN
#endif

I would also put this section in the beginning of utils.h right after the
#include statement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.