[Webkit-unassigned] [Bug 34721] [Chromium] Refactor AutocompletePopupMenuClient into a base class, SuggestionsPopupMenuClient, and two derived classes, AutocompletePopupMenuClient and AutoFillPopupMenuClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34721


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-08 13:12:42 PST ---
Attachment 48358 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:35:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebViewImpl.cpp:1596:  One line control clauses should not
use braces.  [whitespace/braces] [4]
WebKit/chromium/src/SuggestionsPopupMenuClient.h:116:  One space before end of
line comments  [whitespace/comments] [5]
WebKit/chromium/src/SuggestionsPopupMenuClient.cpp:48:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/chromium/src/SuggestionsPopupMenuClient.cpp:241:  Weird number of spaces
at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/chromium/src/SuggestionsPopupMenuClient.cpp:242:  Weird number of spaces
at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/chromium/src/AutoFillPopupMenuClient.cpp:57:  Place brace on its own
line for function definitions.  [whitespace/braces] [4]
Total errors found: 7


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.