[Webkit-unassigned] [Bug 25585] Webkit in Qt _does not have_ window.showModalDialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25585





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-06 07:05:10 PST ---
(From update of attachment 48260)

> +    bool canRun = false;
> +    QMetaObject::invokeMethod(m_webPage, "canRunModal", Qt::DirectConnection, Q_RETURN_ARG(bool, canRun));
> +    return canRun;
>  }

Is the invokeMethod supposed to modify the canRun? I suppose the Q_RETURN_ARG
is a macro modifying it, but if that is the case, please add a comment. 

>  void ChromeClientQt::runModal()
>  {
> -    notImplemented();
> +    QMetaObject::invokeMethod(m_webPage, "runModal", Qt::DirectConnection);
>  }
>  

> @@ -72,7 +72,8 @@
>      Q_PROPERTY(LinkDelegationPolicy linkDelegationPolicy READ linkDelegationPolicy WRITE setLinkDelegationPolicy)
>      Q_PROPERTY(QPalette palette READ palette WRITE setPalette)
>      Q_PROPERTY(bool contentEditable READ isContentEditable WRITE setContentEditable)
> -    Q_ENUMS(LinkDelegationPolicy NavigationType WebAction)
> +    Q_PROPERTY(WebWindowType windowType READ webWindowType)
> +    Q_ENUMS(LinkDelegationPolicy NavigationType WebAction WebWindowType)

This patch introduces new API, please add it to the API tracker bug.

>  public:
>      enum NavigationType {
>          NavigationTypeLinkClicked,
> @@ -247,6 +248,8 @@
>      void setContentEditable(bool editable);
>      bool isContentEditable() const;
>  
> +    WebWindowType webWindowType() const;
> +
>  #ifndef QT_NO_CONTEXTMENU
>      bool swallowContextMenuEvent(QContextMenuEvent *event);
>  #endif
> @@ -301,6 +304,8 @@
>  
>  public Q_SLOTS:
>      bool shouldInterruptJavaScript();
> +    void runModal();
> +    bool canRunModal();


Are these supposed to be virtual?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.