[Webkit-unassigned] [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34317





--- Comment #27 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-05 06:43:44 PST ---
Attachment 48229 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h:47: 
webkit_web_src_get_type is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:25:  Alphabetical
sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:28:  Alphabetical
sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:121:  _doInit is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:135: 
webkit_web_src_base_init is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:148: 
webkit_web_src_class_init is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:203: 
webkit_web_src_init is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:640:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:653:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:660:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:667:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:674:  Use 0 instead
of NULL.  [readability/null] [5]
Total errors found: 12


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.