[Webkit-unassigned] [Bug 34631] [Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34631





--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2010-02-05 06:02:28 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 48203 [details] [details])
> > 
> > > +#include <private/qpaintervideosurface_p.h>
> > 
> > This is going to be an issue, as we cannot include private header files from Qt
> > in WebKit. Is there a way to remove this dependency?
> 
> Whilst this is a private header, it is an exported symbol. There is no
> technical reason why we can not link against this.

The technical reason is that it does not compile, because the private headers
are not installed as part of "make install" in Qt.

It does compile for _our_ builds of Qt as we don't use "make install", but Qt
customers use "make install" for example on Linux or Unix.

We need to be able to compile against an installed version of Qt :)

> Or is this a matter of principle/convention "We WILL not link against private
> headers!"?

It is also a matter of principle indeed, as we intend to be able to support at
least two Qt versions simultaneously, therefore we cannot rely on private Qt
API that is not guaranteed to be source and binary compatible.

> For a variety of reasons, this is not a dependency which can be easily removed.
> 
> I suppose the simplest solution would be to make this a public header - but
> I'll have to speak to Justin before I can say any more on this.

That would be great :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.