[Webkit-unassigned] [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34317





--- Comment #24 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-05 04:02:05 PST ---
(In reply to comment #8)
> Created an attachment (id=47764)
 --> (https://bugs.webkit.org/attachment.cgi?id=47764) [details]
> 0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch
> 
> Lots of style fixes... for the remaining ones, I don't think they should be
> fixed. Using camel case function names is not really GLib'ish and using 0
> instead of NULL in varargs functions is not a good idea either (on x86-64 0
> would be passed as 32 bit value while the function itself wants a 64 bit
> value).

(In reply to comment #8)
> Created an attachment (id=47764)
 --> (https://bugs.webkit.org/attachment.cgi?id=47764) [details]
> 0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch
> 
> Lots of style fixes... for the remaining ones, I don't think they should be
> fixed. Using camel case function names is not really GLib'ish and using 0
> instead of NULL in varargs functions is not a good idea either (on x86-64 0
> would be passed as 32 bit value while the function itself wants a 64 bit
> value).

While I agree with you on this, if we plan to use glibish style on the grounds
that this is a "stand-alone" component that we may want to extract some day,
then this should be considered as a separate API, and moved to WebKit/gtk/,
like the soup http auth dialog was.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.