[Webkit-unassigned] [Bug 34569] Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 01:30:46 PST 2010


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #48210|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #10 from Alexey Proskuryakov <ap at webkit.org>  2010-02-05 01:30:43 PST ---
(From update of attachment 48210)
I now see what you're saying - there's already a branch for null result, so you
are not adding one.

+        // malloc(0) can return 0 in some systems.
+        // To make sure that fastMalloc never returns 0,
+        // retry with fastMalloc(1).

Saying "in some systems" can be confusing. I'd say "Behavior of malloc(0) is
implementation defined". Also, these lines are extremely short, there is no
need to wrap comments like this.

r=me. Someone can fix these when landing, or you could submit a corrected patch
for commit queue.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list