[Webkit-unassigned] [Bug 34569] Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34569


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48192|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org>  2010-02-04 23:56:15 PST ---
(From update of attachment 48192)
I don't see how checking after calling malloc is better than checking before
calling it. Normal case just gets one more branch either way, but fastMalloc(0)
is slower if you check after malloc returns 0.

We don't need to add the branch on platforms that don't return 0, please
protect the new code with preprocessor checks. Any future port that runs into
this can add themselves to the check.

>         (WTF::fastRealloc):

You still had this in ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.