[Webkit-unassigned] [Bug 9526] CSS page-break properties quirk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9526


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47910|review?                     |review-
               Flag|                            |




--- Comment #13 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-04 22:58:44 PST ---
(From update of attachment 47910)
Adding a comment about the test.

> +description("Test page-break-{before,after}:always for overflow:{visible,hidden,scroll,auto} elements.");
> +
> +var overflowValues = ["visible", "hidden", "scroll", "auto"];
> +var pageBreakPositions = ["page-break-before", "page-break-after"];
> +
> +var testNumber = 0;
> +var testHtml = "";
> +for (var position = 0; position < pageBreakPositions.length; position++) {
> +    for (var value = 0; value < overflowValues.length; value++, testNumber++) {
> +        var overflowStyle = "overflow:" + overflowValues[value];
> +        var pageBreakStyle = pageBreakPositions[position] + ":always";
> +        testHtml += '<div style="' + overflowStyle + '"><p id="test' + testNumber + '" style="' + pageBreakStyle + '">' + overflowStyle + ', ' + pageBreakStyle + '</p></div>\n';

I'd use test-visible-page-break-before, test-visible-page-braek-after, ...
instead of test0, test1, ... as their ID. In this way we can see the failing
test easily.

> +var expectedPages = [1, 2, 3, 4, 4, 5, 6, 7, 8];

It would be better to add comments for this expectations.

Also, please fix the style issue the bot is saying.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.