[Webkit-unassigned] [Bug 33383] REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33383





--- Comment #26 from Geoffrey Garen <ggaren at apple.com>  2010-02-04 19:38:15 PST ---
> I think you should reword the comment to give later programmers a fighting
> chance.

Re-worded. I think I'll write a follow-up patch to add a clear(JSCell*)
interface to WeakGCPtr, and use it here. Hopefully, that will encapsulate the
subtlety inside WeakGCPtr.

> > +        // Try to verify that m_jsFunction wasn't recycled. (Not exact, since an
> > +        // event listener can be almost anything, but this makes test-writing easier).
> > +        ASSERT(!m_jsFunction || static_cast<JSC::JSCell*>(m_jsFunction)->isObject());
> 
> Maybe the JSObject class should help you do this debugging check somehow. It's
> a sort of consistency check like the malloc_size calls that Alexey was adding
> recently. It's quite subtle to cast to a JSCell* and then call isObject as a
> consistency check, and so it would be nice if it was somewhere off by itself
> where the technique could be explained.

This is indeed some weird code. I think I can write a follow-up patch to move
this code into JSObject.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.