[Webkit-unassigned] [Bug 34571] [Haiku] Implementation of browser shell

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34571


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48128|review?                     |review-
               Flag|                            |




--- Comment #5 from Oliver Hunt <oliver at apple.com>  2010-02-04 17:21:27 PST ---
(From update of attachment 48128)

> +enum {
> +    HANDLE_SHUTDOWN                        = 'sdwn',
> +
> +    HANDLE_LOAD_URL                        = 'lurl',
> +    HANDLE_GO_BACK                        = 'back',
> +    HANDLE_GO_FORWARD                    = 'fwrd',
> +
> +    HANDLE_DRAW                            = 'draw',
> +
> +    HANDLE_FRAME_RESIZED                = 'rszd'
> +};

This is incorrect, character literals should be a single character, this
triggers warnings in GCC and likely does not do what you are expecting.

Overall i'd also prefer this patch was split into multiple pieces so that it's
easier to review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.