[Webkit-unassigned] [Bug 33568] [BREWMP] Port vprintf_stderr_common

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33568


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47481|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Eric Seidel <eric at webkit.org>  2010-02-04 16:54:04 PST ---
(From update of attachment 47481)
I probably would have made the while loop its own function which took a
Vector<char>& and knew how to walk the vector spitting out chunks to the debug
stream.

This should probably just be "static":
 123     char printBuffer[printBufferSize + 1];

Can VSNPRINTF ever return < 0?  If so, then this code can deadlock.

I guess I would have used buffer.size() to bound my while loop instead of the
return value from VSNPRINTF.  That way you know for sure that you never walk
off the end of the Vector.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.