[Webkit-unassigned] [Bug 25002] Repeated copy/paste can lead to deeply nested divs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 16:23:31 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=25002


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47892|review?                     |review+
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-02-04 16:23:30 PST ---
(From update of attachment 47892)
Not your fault, but I hate it when code uses bools when we should be using
Enums:
 55         NamedNodeMap* attributes =
curBlock->parentElement()->attributes(true);

I have no idea what that does w/o looking at the original function.

Turns out it means "readonly":
    NamedNodeMap* attributes(bool readonly) const;

But then that makes me wonder what plain old "attributes()" returns.  Bah!

Your change itself looks fine.  Looks like it does what it says it does, and
the test looks functional.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list