[Webkit-unassigned] [Bug 34424] Soft modulo routine for ARM_TRADITIONAL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34424





--- Comment #13 from Tamas Szirbucz <Szirbucz.Tamas at stud.u-szeged.hu>  2010-02-04 14:10:59 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > > #ifndef ENABLE_JIT_OPTIMIZE_MOD
> > > #define ENABLE_JIT_OPTIMIZE_MOD (CPU(ARM_TRADITIONAL) &&
> > > WTF_ARM_ARCH_AT_LEAST(5))
> > > #endif
> > 
> > This will not work for non-ARM architectures, because there is no way to break
> > the evaluation of logical expression in a #define. In x86 the #if
> > ENABLE(JIT_OPTIMIZE_MOD) will turn into something similar:
> > #if defined ENABLE_JIT_OPTIMIZE_MOD && CPU(ARM_TRADITIONAL) &&
> > WTF_ARM_ARCH_AT_LEAST(5), where WTF_ARM_ARCH_AT_LEAST is not defined. :(
> 
> I think so, if CPU(ARM_TRADITIONAL) is false, WTF_ARM_ARCH_AT_LEAST will be
> never evaluated in this expression.

Ok, I misread that! Gabor, you are right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.