[Webkit-unassigned] [Bug 34538] audio engine: add Complex number class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 13:41:55 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34538





--- Comment #14 from Chris Rogers <crogers at google.com>  2010-02-04 13:41:52 PST ---
Hi Darin, I've been trying to move forward by changing all the uses of isnan()
in the WebGL header files to std::isnan().  This also required including
<cmath> in all of these header files so that std::isnan() is defined.

But now this appears to be having a cascading effect, and this creates a
compile error in
JSImmediate.h (a use of the signbit() function) in JavaScriptCore.  After
including <cmath> here and using std::signbit(), I'm now getting a compile
error in CachedResource ( function isfinite() ).  I've found that the
isfinite() function is used many places in the codebase, as well as isinf(),
isnan(), etc. etc.

So, I'm not sure what to do.  I'm very uncomfortable trying to do a massive
munge to convert the whole codebase to be <cmath> friendly since I'm very new
here, especially considering possible differences across platforms.  I think it
would be a very large number of changes.

What do you think we should do?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list