[Webkit-unassigned] [Bug 34614] New: npapi header leaves XP_WIN flag defined even when __SYMBIAN32__ flag is found

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34614

           Summary: npapi header leaves XP_WIN flag defined even when
                    __SYMBIAN32__ flag is found
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: S60 Emulator
        OS/Version: S60 3rd edition
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abhinav.mithal at nokia.com
                CC: abhinav.mithal at nokia.com


When MinGW compiler is used to compile Netscape Plugins on Windows XP with Qt,
npapi.h tries to include windows.h. This is because in npapi.h ifdef clause for
__SYMBIAN32__ does not undefine XP_WIN and npapi.h eventually ends up trying to
include windows.h eventhough user is building for Symbian.

This problem is reproducible with nightly build -r54342


Here is the error seen while trying to compile a sample Netscape Plug-in:
make -s  -r -f
"\EPOC32\BUILD\cwrt\plugins\s60\SampleNPQtPlugin\SAMPLENPQTPLUGIN_0XE0AE5E3D\WINSCW\SAMPLENPQTPLUGIN_0XE0AE5E3D.WINSCW"
UDEB
samplenpqtplugin.cpp
npapi.h:116: the file 'windows.h' cannot be opened

Proposed Solution:

add #undef XP_WIN after #define XP_SYMBIAN 1 in the ifdef clause for
__SYMBIAN32__

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.