[Webkit-unassigned] [Bug 18926] dt:after generate a line break. Boost documentation page renders poorly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18926


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47822|review?                     |review-
               Flag|                            |




--- Comment #12 from mitz at webkit.org  2010-02-04 12:04:10 PST ---
(From update of attachment 47822)
> +            if (last != o && !last->isListMarker() && last->style()->styleType() != BEFORE && o->style()->styleType() != AFTER && !last->style()->isDisplayInlineType() && !o->style()->isDisplayInlineType()) {
> +                // better to break between object boundaries than in the middle of a word,
> +                // except for list markers, :before pseudo elements, :after pseudo elements, and inline elements.

I don’t see why you have to single-out :before and :after at all. Presumably
they are inlines too.

But the more I think about this, the less I think this “break between object
boundaries” case is ever the right thing to do. I think the handling of inline
and replaced elements in the main loop now correctly identifies breaking
opportunities, so this branch should never be taken.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.