[Webkit-unassigned] [Bug 34544] Chromium RenderTheme does not draw focus rings on SL for checkboxes, radio buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34544





--- Comment #5 from Avi Drissman <avi at drissman.com>  2010-02-04 08:08:02 PST ---
(In reply to comment #2)
> And I
> couldn't get past the wall of text comment and the poor class name, namespaces
> and methods that have 7604051 littered all over. Be more creative and name
> these things better.

Timothy:

I take it that there were two issues that you had a concern with:

1. The use of "7604051" all over the place.
2. The size of the comment.

Do I read your review correctly?

In response to 1, I agree. The patch section is pretty well-delimited, so
internally it's not necessary to label everything. (Updated patch attached.)

As for 2, I disagree. While I know that WebKit style tends to be comment-light,
there's nothing in the style guide that prohibits explanatory comments. Since
the bug and the fix are both rather opaque, I feel that a comment is definitely
worthwhile in this instance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.