[Webkit-unassigned] [Bug 34573] [Qt] Implement layoutTestController.pageNumberForElementById

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34573





--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-04 04:46:40 PST ---
(From update of attachment 48133)
> diff --git a/WebKit/qt/Api/qwebframe.cpp b/WebKit/qt/Api/qwebframe.cpp
> index aeb7a22..bc00f1b 100644
> --- a/WebKit/qt/Api/qwebframe.cpp
> +++ b/WebKit/qt/Api/qwebframe.cpp
> @@ -214,12 +214,23 @@ QString QWEBKIT_EXPORT qt_drt_counterValueForElementById(QWebFrame* qFrame, cons
>  {
>      Frame* frame = QWebFramePrivate::core(qFrame);
>      if (Document* document = frame->document()) {
> -        Element* element = document->getElementById(id);
> -        return WebCore::counterValueForElement(element);
> +        if (Element* element = document->getElementById(id))
> +            return WebCore::counterValueForElement(element);

This change is not related to this change, but I think it's small enough to fix
with the main change. This change avoids crash when a nonexistent element ID is
specified. If a reviewer considers this should be done in a separate change,
I'm happy to split.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.