[Webkit-unassigned] [Bug 34572] [Gtk] Implement layoutTestController.pageNumberForElementById

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34572





--- Comment #3 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-04 04:24:24 PST ---
(In reply to comment #2)
> Attachment 48131 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: 
> webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming] [4]
> WebKit/gtk/webkit/webkitwebframe.cpp:854:  Use 0 instead of NULL. 
> [readability/null] [5]
> Total errors found: 2

Looks like these files should be in the exception list of our style checker?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.