[Webkit-unassigned] [Bug 34563] websocket/tests/close-on-unload.html failed on Mac Tiger

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34563





--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-04 04:07:31 PST ---
(From update of attachment 48115)
Looks good except for a few nitpicks.

> -connections = set()
> +connections = {}

I'd comment why we don't use set() here so people don't make this fail again.

> +        for ws in connections.keys():

I slightly prefer iterkeys() but it's OK as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.