[Webkit-unassigned] [Bug 34527] [Haiku] Improve/maintain Haiku port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34527





--- Comment #35 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-04 02:06:44 PST ---
Attachment 48122 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
e use: LeakTracker_h  [build/header_guard] [5]
WebKit/haiku/HaikuLauncher/LeakTracker.h:34:  One line control clauses should
not use braces.  [whitespace/braces] [4]
WebKit/haiku/HaikuLauncher/LeakTracker.h:52:  This { should be at the end of
the previous line  [whitespace/braces] [4]
WebKit/haiku/HaikuLauncher/LeakTracker.h:53:  Missing space before ( in if( 
[whitespace/parens] [5]
WebKit/haiku/HaikuLauncher/LeakTracker.h:54:  This { should be at the end of
the previous line  [whitespace/braces] [4]
WebKit/haiku/HaikuLauncher/LeakTracker.h:71:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:133:  One line control
clauses should not use braces.  [whitespace/braces] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:292:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:293:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:294:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:295:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:315:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp:321:  Should have a space
between // and comment  [whitespace/comments] [4]
WebKit/haiku/WebCoreSupport/EditCommandHaiku.h:32:  #ifndef header guard has
wrong style, please use: EditCommandHaiku_h  [build/header_guard] [5]
WebKit/haiku/API/WebView.cpp:39:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/haiku/API/WebView.cpp:165:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
WebKit/haiku/API/WebView.cpp:166:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
WebKit/haiku/API/WebView.cpp:167:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
WebKit/haiku/HaikuLauncher/LauncherApp.h:27:  #ifndef header guard has wrong
style, please use: LauncherApp_h  [build/header_guard] [5]
WebKit/haiku/HaikuLauncher/LauncherApp.cpp:49:  LOAD_AT_STARTING is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebKit/haiku/HaikuLauncher/LauncherApp.cpp:71:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/haiku/API/WebFrame.h:42:  Code inside a namespace should not be
indented.  [whitespace/indent] [4]
WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h:36:  Alphabetical sorting
problem.  [build/include_order] [4]
WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp:595:  Missing space
after ,  [whitespace/comma] [3]
WebKit/haiku/API/WebProcess.h:40:  Code inside a namespace should not be
indented.  [whitespace/indent] [4]
WebKit/haiku/API/WebProcess.h:70:  More than one command on the same line 
[whitespace/newline] [4]
Total errors found: 39


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.