[Webkit-unassigned] [Bug 34555] New: All the different "top tier" classes need to share One True URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34555

           Summary: All the different "top tier" classes need to share One
                    True URL
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: beidson at apple.com


All the different "top tier" classes need to share One True URL.

At the time of me writing this bug, FrameLoader, Document, DOMWindow,
DocLoader, and CachedFrame all have an m_url member that - as far as I can tell
- refer to the same thing:  the real world URL of the document currently in a
frame.

This url is accessible via a ::url() method in each.  When code needs to figure
the url of a document/frame it has a wide array of options for the url() method
to call, and this leads to both confusion and bugs.

And I haven't even mentioned DocumentLoader, which also hangs on to an "m_url"
in the form of "m_request", and there might be others such classes that hold on
to the url via a request also.

I propose that:
-A Document has a URL and a ::url() method.
-FrameLoader, DocLoader, DOMWindow, and CachedFrame all have a 1-to-1
relationship with a Document, should get the url from the Document, and should
have their ::url() methods stripped.
-DocumentLoader has special needs for keeping a resource request around, but we
should explore removing it's ::url() method in case it is being misused

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.