[Webkit-unassigned] [Bug 34539] New: NP_VERSION_MINOR is not correct for some ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539

           Summary: NP_VERSION_MINOR is not correct for some ports
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gns at gnome.org
                CC: andersca at apple.com


I'm not really sure for what ports the version is correct. This was pointed out
to me by Christian Perch, while discussing why the java plugin doesn't work for
us:

 <chpe> PluginPackage.cpp:    m_browserFuncs.version = NP_VERSION_MINOR;
 this line looks wrong, btw.
 that define is the latest version, not the one that you actually implement,
which is 19 I think (at most!)
 if any plugin actually depends on something later, it might crash :)

<kov> I sense platform differences weirdness
 chpe, I believe that is defined inside webkit
 chpe, http://trac.webkit.org/browser/trunk/WebCore/bridge/npapi.h

<chpe> yes, in npapi.h, value "24"
<chpe> but the actually exported functions are only up to
pluginthreadasynccall, aka v19

<kov> right

I'm attaching a patch that conditionalizes the version definition, in the hopes
that we can figure out what should be done here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.