[Webkit-unassigned] [Bug 34527] Improve/maintain Haiku port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34527


Stephan Aßmus <superstippi at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48031|                            |review?
               Flag|                            |




--- Comment #4 from Stephan Aßmus <superstippi at gmx.de>  2010-02-03 07:40:51 PST ---
Created an attachment (id=48031)
 --> (https://bugs.webkit.org/attachment.cgi?id=48031)
Fixes to rect conversion and image rendering on Haiku

The patch can be applied individually.

The changes to the rect conversions are indeed correct. In Haiku (to stay
compatibly with BeOS), a BRect specifies the left/top and bottom/right pixel
*indices*, even though the values are floating point. So a rectangle covering
just one pixel would be specified as BRect(0, 0, 0, 0). In WebCore and other
frame works, such rectangles would be expressed as 0, 0, 1, 1. In WebCore, the
width and height of rectangles refer to the distance between pixels, while on
Haiku, a one pixel rect has indeed a width and height of 0, as confusing as
that may be.

The part of the patch that affects
WebCore/platform/graphics/haiku/ImageHaiku.cpp also implements the drawing
methods more correctly. Image observers are notified, and pattern drawing takes
the "phase" into account which makes scrolled backgrounds render correctly.
Transformations are still not supported, since the Haiku drawing backend itself
does not yet support them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.